geoffreyclaude commented on PR #26118: URL: https://github.com/apache/datafusion/pull/26118#issuecomment-6384096090
> The fix for the `-a AS a` case looks right to me. Two comments inline: one on keeping pushdown for transparent custom nodes, and one on documenting the behavior change. @jayzhan211 Thanks for the in-depth review! I'm going back to design as I'm not happy with the current approach. I'll take your suggestions into account and put this back in draft in the meantime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
