LucaCappelletti94 commented on code in PR #2713: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2713#discussion_r4367136725
########## AGENTS.md: ########## @@ -18,7 +18,7 @@ ## Unit Tests Guidelines - New unit tests should be added to the `tests` module in the corresponding dialect file (e.g., `tests/sqlparser_redshift.rs` for Redshift), and should be placed at the end of the file. - If the new functionality is gated using a dialect function, and the SQL is likely relevant in most dialects, tests should be placed under `tests/sqlparser_common.rs`. -- Cover both positive and negative cases: valid input parses and round-trips, invalid input fails with the expected error. +- Cover both positive and negative cases: valid input parses and round-trips, invalid input fails with the expected error. For some of them, assert the exact error text on a full statement, not just `is_err()`. Review Comment: I thought this was already blocked by the clippy lint now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
