patrickswedish commented on PR #26006: URL: https://github.com/apache/datafusion/pull/26006#issuecomment-6385697611
Thank you @kosiew for the thorough architectural review and approval! I have addressed all the non-blocking suggestions: 1. **Dictionary Cross-Code Ordering**: Updated est_compare_join_arrays_extended_types using DictionaryArray::try_new with independently ordered codes (pple at code 0 in left, code 1 in right; anana at code 1 in left, cherry at code 0 in right) to verify value-based comparison across differing encodings. 2. **Table-Driven Comparator Tests**: Consolidated the extended type test cases into a structured table loop with descriptive failure assertions. 3. **Execution-Level Stream Boundary Regression**: Added join_timestamp_tz_key_batch_boundaries across 96 parameter combinations covering timezone-aware timestamp keys with duplicate groups continuing across batch boundaries for semi, anti, and mark joins. All tests pass locally. Marked ready for review @alamb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
