abp002 commented on PR #26596: URL: https://github.com/apache/datafusion/pull/26596#issuecomment-6386191781
Thanks for verifying. I changed the `unwrap()` to an `expect()` that says why the kept predicates can't be empty, and rebased on main again (it conflicted with #26551 in `subquery.slt`; both sets of tests are kept). On the `ScalarSubquery` arm: as @namanjain24-sudo showed, it's reachable but nothing downstream depends on it, so I've left it without a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
