github-actions[bot] commented on PR #26733: URL: https://github.com/apache/datafusion/pull/26733#issuecomment-6393755764
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning c61fb09ac123d669382287ceb7b8f36267fc4711 Building datafusion-physical-plan v55.1.0 (current) Built [ 44.439s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.247s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 13.401s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.234s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.667s] 229 checks: 226 pass, 3 fail, 0 warn, 31 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/function_missing.ron Failed in: function datafusion_physical_plan::aggregates::topk_types_supported, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-c61fb09ac123d669382287ceb7b8f36267fc4711/baa82be3ac677ebd6d937035b172a8de38bac165/datafusion/physical-plan/src/aggregates/mod.rs:238 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/inherent_method_missing.ron Failed in: AggregateExec::get_minmax_desc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-c61fb09ac123d669382287ceb7b8f36267fc4711/baa82be3ac677ebd6d937035b172a8de38bac165/datafusion/physical-plan/src/aggregates/mod.rs:1929 AggregateExec::is_unordered_unfiltered_group_by_distinct, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-c61fb09ac123d669382287ceb7b8f36267fc4711/baa82be3ac677ebd6d937035b172a8de38bac165/datafusion/physical-plan/src/aggregates/mod.rs:1938 --- failure inherent_method_now_doc_hidden: inherent method #[doc(hidden)] added --- Description: A method or associated fn is now #[doc(hidden)], removing it from the crate's public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/inherent_method_now_doc_hidden.ron Failed in: AggregateExec::input_keeps_groups_local in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-c61fb09ac123d669382287ceb7b8f36267fc4711/baa82be3ac677ebd6d937035b172a8de38bac165/datafusion/physical-plan/src/aggregates/mod.rs:1776 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 60.602s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
