Smallfu666 commented on PR #6179: URL: https://github.com/apache/datafusion-comet/pull/6179#issuecomment-6395543376
Thanks! These can't fail, so I added boolean to numeric, string and integral to binary, and array or struct keys to `keyCastCannotFail`. A failing element inside an array or struct key only becomes a null element, so the key itself is never null. The boolean, binary and array cases now have `expect_native(try_cast)` coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
