dwsmith1983 commented on code in PR #7221:
URL: https://github.com/apache/datafusion-comet/pull/7221#discussion_r4371417138
##########
docs/source/user-guide/latest/datasources.md:
##########
@@ -479,15 +479,15 @@ hadoop-azure must be on the driver classpath. It already
is whenever Spark can l
| `WorkloadIdentityTokenProvider` with a
`fs.azure.account.oauth2.client.assertion.provider.type` (hadoop-azure 3.5.0
and later) | Not supported |
|
| `UserboundSASWithOAuth` (hadoop-azure 3.5.0 and later)
| Not supported |
|
-Custom provider classes hand each token request to Java code the native scan
cannot call, and the refresh token and user password flows have no
`object_store` counterpart. When Hadoop selects one of these, the scan fails
with an error naming the auth type and, where one is configured, the class.
Configure a supported mechanism for that account, or keep the path on Spark's
own scan. Values arrive as Hadoop resolved them, trimmed and defaulted where
the ABFS driver trims and defaults them, so the store sees what the driver
would have used.
+Custom provider classes hand each token request to Java code the native scan
cannot call, and the refresh token and user password flows have no
`object_store` counterpart. When Hadoop selects one of these, the scan falls
back to Spark's own scan, which authenticates through hadoop-azure, and the
fallback reason names the auth type and, where one is configured, the class.
Configure a supported mechanism for that account to read it natively. Values
arrive as Hadoop resolved them, trimmed and defaulted where the ABFS driver
trims and defaults them, so the store sees what the driver would have used.
Review Comment:
"names the auth type and, where one is configured, the class": for `Custom`,
`resolve` returns `Declined(other, None)`, so the reason is only `auth type
Custom` even with `fs.azure.account.oauth.provider.type` set. The `Custom` test
sets that class but checks only the auth type. Either name the class for
`Custom` too, or say here that the class is named for SAS and Workload Identity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
