Nagato-Yuzuru commented on code in PR #26086:
URL: https://github.com/apache/datafusion/pull/26086#discussion_r4375789276
##########
datafusion/core/tests/fuzz_cases/equivalence/ordering.rs:
##########
@@ -127,10 +171,21 @@ fn
test_ordering_satisfy_with_equivalence_complex_random() -> Result<()> {
col("f", &test_schema)?,
floor_a,
a_plus_b,
+ a_gt_b,
+ a_gt_e_and_b_gt_e,
+ a_gt_e_or_b_gt_e,
];
+ let mut options_rng = StdRng::seed_from_u64(seed as u64);
for n_req in 1..=exprs.len() {
for exprs in exprs.iter().combinations(n_req) {
Review Comment:
Thanks. I measured it locally with --profile ci --features extended_tests:
| | before this PR |
this PR, no sampling | this PR, sampling |
|-------------------------------------------------------|----------------|----------------------|-------------------|
| test_ordering_satisfy_with_equivalence_complex_random | 2.0 s |
82.9 s | 11.5 s |
To check that NULL ordering regressions stay detectable, I removed the NULL
guards in SortProperties::and/or and in SortProperties::gt_or_gteq locally, one
at a time. The sampled test fails in both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
