kosiew opened a new pull request, #26766: URL: https://github.com/apache/datafusion/pull/26766
> [!IMPORTANT] > > **Fork CI setup:** For pull requests from a fork to `main`, enable workflows in your fork's **Actions** tab before you push. > See the [fork CI setup guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks). ## Which issue does this PR close? - Follow up to #25836 [comment](https://github.com/apache/datafusion/pull/25836#issuecomment-6364807577) ## Rationale for this change The required `microbenchmark tests (amd64)` job consumes approximately 10 runner minutes per merge-queue run. This recurring cost is not justified under the current maintainer resource constraints. This PR moves full microbenchmark health checks to local-only execution, eliminating their automatic CI cost and merge requirement. Runtime-only failures may remain undetected until a contributor explicitly runs the benchmarks. ## What changes are included in this PR? - Remove the microbenchmark job from `.github/workflows/extended.yml`, including automatic execution on merge groups and release pushes. - Remove `microbenchmark tests (amd64)` from the required checks in `.asf.yaml`, leaving other requirements unchanged. - Retain the existing local `cargo xtask ci step test microbenchmarks` command and its execution semantics without introducing a dedicated hosted workflow. - Document existing benchmark compilation coverage through Clippy's `--workspace --all-targets --all-features` checks, including required feature gates and coverage limitations. - Update the contributor guide with local execution instructions, expectations for benchmark-related PRs, and the accepted risk of delayed runtime-failure detection. ## What is the testing strategy for this PR? No new automated tests are included. This change modifies CI configuration and documentation without changing the benchmark implementation. Existing Clippy checks retain benchmark compilation coverage, while the full benchmark health-check command remains available locally. The patch does not establish that the required-check validator, local benchmark command, documentation formatting checks, or affected workflow-policy tests have been run. Merge-queue behavior must also be verified after merge. ## Are there any user-facing changes? No changes to DataFusion's public APIs or query behavior. For contributors and maintainers, full microbenchmark health checks are no longer automatically executed or required for merging. They must be run locally using: ```shell cargo xtask ci step test microbenchmarks ``` No dedicated GitHub Actions workflow is provided. The contributor documentation has been updated accordingly. ## LLM-generated code disclosure This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
