xavlee commented on code in PR #24698:
URL: https://github.com/apache/datafusion/pull/24698#discussion_r4380258918
##########
datafusion/expr-common/src/sort_properties.rs:
##########
@@ -37,16 +37,24 @@ use arrow::datatypes::DataType;
pub enum SortProperties {
/// Use the ordinary [`SortOptions`] struct to represent ordered data:
Ordered(SortOptions),
- // This alternative represents unordered data:
+ /// Within each partition, all rows with the same value for this expression
+ /// form one contiguous run. The runs may occur in any order.
+ Grouped,
Review Comment:
Hi Jay, sorry for the late reply as I was offline the last two weeks.
Thanks for tracing through this and confirming that our use case does not
require the new property-- if it's tenable to ship this without
cast-through-projection, I'm happy to remove it. Should I file an issue for
this in case we want to pick it up in the future?
As for the near-term, i'll implement your suggestion to remove the
SortProperties::Grouped enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
