xavlee commented on code in PR #24698:
URL: https://github.com/apache/datafusion/pull/24698#discussion_r4381795603
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1781,17 +1786,19 @@ impl AggregateExec {
group_expr_mapping: &ProjectionMapping,
is_true_no_grouping: bool,
mode: &AggregateMode,
- input_order_mode: &InputOrderMode,
+ group_clustering_mode: &GroupClusteringMode,
aggr_exprs: &[Arc<AggregateFunctionExpr>],
) -> Result<PlanProperties> {
// Construct equivalence properties:
let mut eq_properties = input
.equivalence_properties()
.project(group_expr_mapping, schema);
Review Comment:
Thanks- I originally had it in the followup but it should be moved here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
