github-actions[bot] commented on PR #26789: URL: https://github.com/apache/datafusion/pull/26789#issuecomment-6433016363
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning c18e5d974c49382ba892fa9f89ce71d3aa0ab8ae Building datafusion v55.1.0 (current) Built [ 40.556s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion v55.1.0 (baseline) Built [ 11.831s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.425s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 54.753s] datafusion Building datafusion-catalog-listing v55.1.0 (current) Built [ 12.635s] (current) Parsing datafusion-catalog-listing v55.1.0 (current) Parsed [ 0.006s] (current) Building datafusion-catalog-listing v55.1.0 (baseline) Built [ 9.791s] (baseline) Parsing datafusion-catalog-listing v55.1.0 (baseline) Parsed [ 0.006s] (baseline) Checking datafusion-catalog-listing v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.062s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 23.248s] datafusion-catalog-listing Building datafusion-common v55.1.0 (current) Built [ 11.446s] (current) Parsing datafusion-common v55.1.0 (current) Parsed [ 0.052s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 0.784s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.053s] (baseline) Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.547s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field OptimizerOptions.enable_dictionary_optimization in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1634 field OptimizerOptions.dictionary_encoding_min_rows_per_distinct_value in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1634 field OptimizerOptions.dictionary_encoding_min_average_value_bytes in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1634 field ParquetOptions.rle_to_dictionary_max_distinct_values in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:1321 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 13.764s] datafusion-common Building datafusion-datasource v55.1.0 (current) Built [ 11.163s] (current) Parsing datafusion-datasource v55.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-datasource v55.1.0 (baseline) Built [ 10.905s] (baseline) Parsing datafusion-datasource v55.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-datasource v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.186s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 23.159s] datafusion-datasource Building datafusion-datasource-parquet v55.1.0 (current) Built [ 14.495s] (current) Parsing datafusion-datasource-parquet v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-datasource-parquet v55.1.0 (baseline) Built [ 11.710s] (baseline) Parsing datafusion-datasource-parquet v55.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.115s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 27.345s] datafusion-datasource-parquet Building datafusion-execution v55.1.0 (current) Built [ 6.349s] (current) Parsing datafusion-execution v55.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-execution v55.1.0 (baseline) Built [ 3.622s] (baseline) Parsing datafusion-execution v55.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-execution v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.222s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field CachedFileMetadata.physical_statistics in /home/runner/work/datafusion/datafusion/datafusion/execution/src/cache/cache_manager.rs:110 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 11.109s] datafusion-execution Building datafusion-physical-optimizer v55.1.0 (current) Built [ 0.548s] (current) Parsing datafusion-physical-optimizer v55.1.0 (current) Parsed [ 0.015s] (current) Building datafusion-physical-optimizer v55.1.0 (baseline) Built [ 0.537s] (baseline) Parsing datafusion-physical-optimizer v55.1.0 (baseline) Parsed [ 0.014s] (baseline) Checking datafusion-physical-optimizer v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.092s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 2.059s] datafusion-physical-optimizer Building datafusion-proto v55.1.0 (current) Built [ 16.330s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.009s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 13.927s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.010s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.082s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 31.242s] datafusion-proto Building datafusion-proto-common v55.1.0 (current) Built [ 8.639s] (current) Parsing datafusion-proto-common v55.1.0 (current) Parsed [ 0.038s] (current) Building datafusion-proto-common v55.1.0 (baseline) Built [ 1.881s] (baseline) Parsing datafusion-proto-common v55.1.0 (baseline) Parsed [ 0.048s] (baseline) Checking datafusion-proto-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.849s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.rle_to_dictionary_max_distinct_values_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:921 field ParquetOptions.rle_to_dictionary_max_distinct_values_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:921 field ParquetOptions.rle_to_dictionary_max_distinct_values_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-common/src/generated/prost.rs:921 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 12.184s] datafusion-proto-common Building datafusion-proto-models v55.1.0 (current) Built [ 2.460s] (current) Parsing datafusion-proto-models v55.1.0 (current) Parsed [ 0.113s] (current) Building datafusion-proto-models v55.1.0 (baseline) Built [ 2.568s] (baseline) Parsing datafusion-proto-models v55.1.0 (baseline) Parsed [ 0.114s] (baseline) Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.367s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetOptions.rle_to_dictionary_max_distinct_values_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:921 field ParquetOptions.rle_to_dictionary_max_distinct_values_opt in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/datafusion_proto_common.rs:921 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 7.523s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
