dwsmith1983 commented on code in PR #26228:
URL: https://github.com/apache/datafusion/pull/26228#discussion_r4385714949
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -3275,21 +3267,13 @@ fn build_in_memory(
true,
null_equality,
)?;
- offset += batch.num_rows();
}
// Merge all batches into a single batch, so we can directly index
into the arrays
let batch = if prepared {
Review Comment:
Makes sense. I'd rather keep this PR as is so it can merge, and do the
concat-first change on its own in #26792. I'll post hj numbers and build peak
memory against main there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
