alamb commented on issue #11822: URL: https://github.com/apache/datafusion/issues/11822#issuecomment-2337737561
> So I've implemented this in a local branch with all dates being converted to timestamps which may/will break any existing query that expects a date32 out but gets a timestamp instead. I'm not terribly comfortable with that so I think I may change the proposed implementation as follows: > > 1. Number range/generate_series stays identical to what exists today. > 2. If the start is anything but a timestamp it follows the existing behaviour today. That includes limiting the interval to no less than a day. > 3. If the start is a timestamp intervals down to a nanosecond are supported, and timestamps with time zones are also supported. What I don't think will be supported will checks on ranges to verify that a range covering a discontinuity in the times (say when crossing a daylight savings change) is handled in a manner that is 100% correct. This makes sense to me @Omega359 -- thank you . > That behaviour would be no different than what exists in the code today. I think it makes sense to start with getting the basics down, and maybe documenting that there are potential inconsistencies in certain cases. Then that behavior can be more easily improved by anyone who needs it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
