kosiew commented on code in PR #25811: URL: https://github.com/apache/datafusion/pull/25811#discussion_r4388126431
########## datafusion/core/Cargo.toml: ########## @@ -245,10 +245,6 @@ name = "math_query_sql" harness = false name = "filter_query_sql" -[[bench]] -harness = false Review Comment: Removing this `[[bench]]` entry drops `harness = false` for `in_list_rewrite`, so Cargo auto-discovers it with the default libtest harness instead of running its Criterion entry point. Could you restore the existing benchmark stanza unchanged and keep the new benchmark registration separate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
