andygrove commented on issue #6934: URL: https://github.com/apache/datafusion-comet/issues/6934#issuecomment-6443500938
A note for whoever does this bump. apache/iceberg-rust#2930 merged on 2026-10-15, after the pin at `1f3bc34`. It tags Iceberg UUID fields with the Arrow `arrow.uuid` extension in `schema_to_arrow_schema`, and `crates/iceberg` already enables `arrow_canonical_extension_types` on `parquet`. I expect that to make the native writer emit the Parquet `UUID` logical type, which the pinned revision omits. I haven't tried a bump to confirm. #7198 adds native UUID writes and documents the missing annotation as an accepted divergence from iceberg-java (see #6959). It also has a test assertion, `leaf.getLogicalTypeAnnotation == null` in `CometIcebergWriteActionSuite`, that pins the divergence. Once the target revision includes #2930, that assertion will fail, so the bump should flip it, remove the divergence entry from the Writes section of `iceberg.md`, and check the written footer against iceberg-java's. The target revision therefore needs to be at or after `f83bec4` (the merge commit of #2930), not only past #3255 (merged 2026-10-11). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
