github-actions[bot] commented on PR #26808: URL: https://github.com/apache/datafusion/pull/26808#issuecomment-6443110102
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 6286f5e6053a6fd8040b6f9ce054ecbc81e25832 Building datafusion v55.1.0 (current) Built [ 68.850s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.037s] (current) Building datafusion v55.1.0 (baseline) Built [ 20.662s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.042s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.629s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 91.889s] datafusion Building datafusion-expr v55.1.0 (current) Built [ 25.130s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.111s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 8.258s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.112s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.488s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct has a new non-public field that causes downstream code to be unable to construct it with a struct expression, including functional-update syntax. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_private_field.ron Failed in: field WindowFrameStateGroups.sort_options in /home/runner/work/datafusion/datafusion/datafusion/expr/src/window_state.rs:637 field WindowFrameStateGroups.peer_comparator in /home/runner/work/datafusion/datafusion/datafusion/expr/src/window_state.rs:639 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 35.982s] datafusion-expr Building datafusion-functions-window v55.1.0 (current) Built [ 17.916s] (current) Parsing datafusion-functions-window v55.1.0 (current) Parsed [ 0.011s] (current) Building datafusion-functions-window v55.1.0 (baseline) Built [ 7.877s] (baseline) Parsing datafusion-functions-window v55.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-functions-window v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.105s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 26.554s] datafusion-functions-window ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
