pingzh opened a new pull request, #7260:
URL: https://github.com/apache/datafusion-comet/pull/7260

   ## Which issue does this PR close?
   
   Part of #6741. First of four smaller changes replacing #7117.
   
   ## Rationale for this change
   
   An identity broadcast retains every input row, but the JVM columnar-to-row 
converters reuse their row object. Materializing that iterator can therefore 
repeat the last row of each batch instead of preserving the build rows.
   
   ## What changes are included in this PR?
   
   Copy each row when adapting a Comet broadcast to `IdentityBroadcastMode`. 
Hashed broadcast modes already copy row data into their own storage. This fix 
is independent of the make_date evaluation changes.
   
   ## How are these changes tested?
   
   A focused regression directly converts an identity broadcast containing four 
distinct rows across two partitions. It verifies retained values and 
cardinality with the direct JVM converter enabled and disabled.
   
   Full-reactor JVM and test-source compilation passes on Spark 4.1 / JDK 17, 
including formatting and style checks. Runtime execution is blocked because the 
configured native dependency registry does not contain the locked `aws-config 
1.13.0` package.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to