Kontinuation commented on code in PR #929:
URL: https://github.com/apache/datafusion-comet/pull/929#discussion_r1750320103
##########
common/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/ArrowReaderIterator.scala:
##########
@@ -42,10 +46,12 @@ class ArrowReaderIterator(channel: ReadableByteChannel,
source: String)
// memory leak.
if (currentBatch != null) {
currentBatch.close()
+ currentBatch = null
}
batch = nextBatch()
if (batch.isEmpty) {
+ close()
Review Comment:
This is because I am paranoid and want to close the iterator early. I can
revert changes to this file if you don't like it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
