alamb opened a new pull request, #24: URL: https://github.com/apache/datafusion-testing/pull/24
## Rationale apache/datafusion#26548 teaches `EliminateFilter` that `x NOT IN (..., NULL)` can never be `TRUE` under filter semantics, so such a filter is rewritten to an empty relation. One sqlite test in this repo expected a divide-by-zero error from an expression *inside* such a `NOT IN` list: ```sql SELECT ALL * FROM tab0 WHERE ( + col2 / col2 * + col1 ) NOT IN ( col2 + - col0 / 0, - 1, + - CAST ( NULL AS INTEGER ) ) ``` With the filter eliminated, the division is never evaluated and the query returns no rows. That is the original sqlite expected result, so the `# Datafusion - Datafusion expected results:` marker is dropped along with the `query error` expectation. This fixes the extended CI failure reported in https://github.com/apache/datafusion/pull/26548#issuecomment-6447155326 ## Changes Update one expectation in `data/sqlite/random/aggregates/slt_good_14.slt` (line 53882) from a divide-by-zero error to an empty result. ## Testing Pointed DataFusion's `datafusion-testing` submodule at this branch, checked out apache/datafusion#26548 (`2b705277e2`), and ran the same command as the extended CI job: ``` cargo test --features backtrace,parquet_encryption --profile ci-optimized --test sqllogictests -- --include-sqlite ``` The modified file passes. Full-suite run in progress; I will update this description with the result. Note: this must be merged together with (or before) apache/datafusion#26548, which needs its submodule pointer updated to this commit. Until then `main` of DataFusion will fail on this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
