akshaychitneni commented on code in PR #2633:
URL:
https://github.com/apache/datafusion-ballista/pull/2633#discussion_r4395396207
##########
ballista/core/src/extension.rs:
##########
@@ -75,6 +76,25 @@ pub fn ballista_window_functions() -> Vec<Arc<WindowUDF>> {
all_default_window_functions()
}
+/// Lets a scheduler session plan `DataFrame::cache()` reads.
+pub trait SessionStateBuilderExt {
+ /// Installs [CacheReadQueryPlanner], so the session can plan a
+ /// `DataFrame::cache()` read, unless a query planner is already set: a
+ /// planner the builder's author chose is kept, and that author adds
+ /// [CacheReadPlanner](crate::cache::CacheReadPlanner) to it instead, for
+ /// example with [CacheReadQueryPlanner::with_extension_planners].
+ fn with_cache_read_planner(self) -> Self;
+}
+
+impl SessionStateBuilderExt for SessionStateBuilder {
+ fn with_cache_read_planner(mut self) -> Self {
Review Comment:
Fixed by making the read planner-independent: a cache is now read through a
plain TableScan, so any session plans it. Your cache_with_state test is in,
over a self-join to cover restored qualifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
