ninglinLiu commented on PR #7219: URL: https://github.com/apache/datafusion-comet/pull/7219#issuecomment-6456440985
Thanks @sunchao — reproduced the July LA case and addressed it in a27437a. `chrono-tz` stops applying DST after ~2099, so looking the offset up at the cycle-shifted year (~+242000) silently used standard time (−08:00) and disagreed with Spark by an hour. The out-of-range path now projects the wall time into year 2000 before the offset lookup (leap year, inside chrono-tz’s transition window), which matches Spark’s last-rule-forever behaviour for `+280000-07-15 12:00:00` in `America/Los_Angeles` (`8773796318400000000` → `8773796343600000000`). Also restored the July far-future SQL fixture row and added `test_timestamp_ntz_to_timestamp_far_future_july_uses_dst_offset`. The native unit tests for the NTZ helpers pass locally; the head CI run will still need fork-workflow approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
