andygrove opened a new pull request, #7291:
URL: https://github.com/apache/datafusion-comet/pull/7291

   ## Which issue does this PR close?
   
   Part of #6550. Fixes the 1.2.0 changelog from #7290.
   
   ## Rationale for this change
   
   `dev/release/generate-changelog.py` finds the pull request for each commit 
with GitHub's commit-to-PR lookup, and skips a commit that has none. 
`cc6535c0b2`, the squash commit of #7281 (the `branch-1.2` backport of #6940), 
has none. The REST endpoint and GraphQL `associatedPullRequests` both return an 
empty list for it, although #7281 reports `cc6535c0b2` as its merge commit. I 
ran the lookup for all 396 commits between `992c806a7e` and `4bda15db3e`, and 
this is the only one without a pull request. So #7290 lists every backport 
except #7281.
   
   ## What changes are included in this PR?
   
   Adds the missing entry to "Implemented enhancements" in 
`docs/source/changelog/1.2.0.md`, in the format the script prints:
   
   ```
   - feat: [branch-1.2] support the S3A magic committer in native Parquet 
writes (#6940) [#7281](https://github.com/apache/datafusion-comet/pull/7281) 
(andygrove)
   ```
   
   It sits last in the section, which is where the commit order puts it. The 
commit count and credits already include the commit, because they come from 
`git log` and `git shortlog`.
   
   If the changelog is regenerated before the release candidate, this entry has 
to be added again, unless GitHub has repaired the association by then.
   
   ## How are these changes tested?
   
   Prettier passes on the file. The link and the title match #7281.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to