osipovartem commented on PR #26145: URL: https://github.com/apache/datafusion/pull/26145#issuecomment-6476707449
Thanks. CASE is a separate logical drop site: direct `Expr::Case::to_field` does not call the COALESCE/NVL `ScalarUDF::return_field_from_args()` methods fixed in #24865. I agree the metadata merge policy should be centralized. `intersect_metadata_for_union()` is not equivalent to the reviewed `coerced_fields_metadata` in #24865: it intersects ordinary keys and can silently drop a conflicting extension name, whereas #24865 uses earlier-key precedence and rejects incompatible extension names. I will reuse the shared helper once #24865 lands, keep this PR draft until then, and revisit whether the CASE branch-resolution logic can be simplified without losing nested CASE/cast/alias behavior or the plain-CASE fast path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
