lewiszlw commented on code in PR #11627:
URL: https://github.com/apache/datafusion/pull/11627#discussion_r1751582329
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -365,6 +459,36 @@ impl GroupedHashAggregateStream {
merging_group_by:
PhysicalGroupBy::new_single(agg_group_by.expr.clone()),
};
+ // Skip aggregation is supported if:
+ // - aggregation mode is Partial
+ // - input is not ordered by GROUP BY expressions,
+ // since Final mode expects unique group values as its input
Review Comment:
Hello @korowa , I have a question about this comment.
I thought input is required no group ordering here is because we can emit
groups early if we have group ordering.
https://github.com/apache/datafusion/blob/dbc78902582f4a63fc26d7359018ae85d2051343/datafusion/physical-plan/src/aggregates/row_hash.rs#L645
But it confused me when I saw your comment. Is comment not updated or I
misunderstood?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
