timsaucer commented on code in PR #868:
URL: https://github.com/apache/datafusion-python/pull/868#discussion_r1752210575
##########
src/expr.rs:
##########
@@ -293,6 +293,17 @@ impl PyExpr {
expr.into()
}
+ #[pyo3(signature = (low, high, negated=false))]
Review Comment:
FYI for optionals we might have to have these signatures in when we upgrade
to pyo3 0.22. It's part of the DF42 update PR that's up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]