siddubakka commented on PR #26723: URL: https://github.com/apache/datafusion/pull/26723#issuecomment-6507937543
Thanks for writing this up, I read the #5492 note too and get the concern about a nonstop stream of subquery patches. For this one what it extends already exists on main (the unmatched-row CASE with the join indicator) and this PR just adds the HAVING piece into that same mechanism. +175/-2 across three files, not a new rewrite path. Every case is pinned in subquery.slt against the same queries run on Postgres and jayzhan211's latest review confirmed the results match Postgres. I applied his last narrowing of the gate just now. You noted a simple fix is fine when it really is simple. So does this one read that way to you or would you rather this pattern raise an optimizer error instead? Happy to switch if that's the better direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
