parthchandra commented on PR #7191: URL: https://github.com/apache/datafusion-comet/pull/7191#issuecomment-6509559904
> The [current-head wide-payload performance finding](https://github.com/apache/datafusion-comet/pull/7191#discussion_r4407341369) remains unresolved. The implementation still encodes every complete struct before selecting the winner, including payloads whose leading key already loses. The published matched pipeline benchmark applies to this exact unchanged head. I rechecked the source and its measurement boundary without rerunning or presenting those timings as new measurements. @sunchao I filed https://github.com/apache/datafusion-comet/issues/7323 for this. Is that okay as a follow up or would you prefer it be addressed in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
