devanbenz commented on code in PR #26249:
URL: https://github.com/apache/datafusion/pull/26249#discussion_r4424892570
##########
datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:
##########
@@ -312,16 +369,101 @@ impl HashTableLookupExpr {
Self {
on_columns,
random_state,
- map,
+ lookup: Lookup::Single(map),
description,
pruning_bitmap,
}
}
+ /// Looks each probe row up in the hash table of the build partition
+ /// `router` assigns it to. `maps` holds one entry per partition, each a
+ /// [`Map::HashMap`] or `None` for an empty partition, and `pruning_bitmap`
+ /// must cover every partition's keys.
+ pub(crate) fn new_routed(
Review Comment:
I think I'll just remove the `_routed` from here and sub in the `new` method
with this one. Since it's just the default way the `HashTableLookupExpr` will
be created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
