colinmarc commented on PR #91: URL: https://github.com/apache/datafusion-iceberg/pull/91#issuecomment-6524324071
> datafusion-iceberg depends on iceberg-rust at rev `5b82ab9` ([Cargo.toml#L40-L41](https://github.com/apache/datafusion-iceberg/blob/8979482936eff6509e40c2e4e3bfc1235d965d60/Cargo.toml#L40-L41)). If [apache/iceberg-rust#3574](https://github.com/apache/iceberg-rust/pull/3574) merges while it rounds timestamps down to dates, bumping the rev past it before this PR lands turns `d < TIMESTAMP '2023-01-05 12:00:00'` from an error into a predicate that drops the `2023-01-05` rows. Could we merge this PR before any bump past #3574? If #3574 ends up returning an error for timestamp to date conversion instead, the order no longer matters. I removed the timestamp -> date conversion from that PR, so I think it should be fine either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
