Michael-J-Ward commented on code in PR #12431:
URL: https://github.com/apache/datafusion/pull/12431#discussion_r1754988347
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -2984,19 +2990,25 @@ mod tests {
let df_impl = DataFrame::new(ctx.state(), df.plan.clone());
let func = row_number().alias("row_num");
+ // This first `with_column` results in a column without a `qualifier`
+ let df_impl = df_impl.with_column("s", col("c2") + col("c3"))?;
+
+ // This second `with_column` then assigns `"r"` alias to the above
column and the window function
Review Comment:
```suggestion
// This second `with_column` should only alias `func` as `"r"`
```
Update the comment from explaining the bug to explaining the correct the
behavior.
The comment for this test case already links to GH issue, so maybe add a
link to this bug as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
