goldmedal commented on PR #12401:
URL: https://github.com/apache/datafusion/pull/12401#issuecomment-2344078155
> I think it's not executed and triggered some error, see benchmark
`StringArray` cases only take several ns, and `StringViewArray` cases are at
least several us I guess it's because in micro bench, arguments are of
different physical string type and break the function implementation
(`strpos(string_col, string_view_col)`)
You're right. There are some errors here. I ran the benchmark in the
`strpos` test case and got the following error:
```
Error: Execution("Unsupported data type combination (Utf8, Utf8View) for
function strpos")
```
It seems that `strpos` doesn't allow the second argument to be a
`StringView` if the first one is a `StringArray`. I'm not sure if this case
makes sense. Maybe we can file another issue for it if it's reasonable.
Then, I realized it was my mistake 😢. When I generated the substring for the
`StringArray`, I mistakenly set its type to `StringView`. After fixing it, the
benchmark for `StringArray` works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
