LucaCappelletti94 commented on code in PR #2434:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2434#discussion_r4428456295
##########
src/ast/spans.rs:
##########
@@ -528,6 +529,12 @@ impl Spanned for Statement {
}
}
+impl Spanned for DropRule {
Review Comment:
Added all the tests, but I have not understood what is there to like in
particular of the Span? Unfortunately most of the spans are objectively to be
refactored, likely including this one, but that is something I will only touch
at some point after the tokenizer refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
