mkleen commented on code in PR #26753:
URL: https://github.com/apache/datafusion/pull/26753#discussion_r4430985901
##########
datafusion/spark/src/function/aggregate/avg.rs:
##########
@@ -381,6 +385,14 @@ mod tests {
use super::*;
use arrow::array::Float64Array;
+ #[test]
+ fn avg_reports_distinct_as_unsupported() {
+ assert_eq!(
+ SparkAvg::new().distinct_handling(),
+ DistinctHandling::Unsupported
Review Comment:
This only checks the constant. Could we also cover the behaviour in the slt
files?
##########
datafusion/spark/src/function/aggregate/collect.rs:
##########
@@ -105,6 +107,10 @@ impl AggregateUDFImpl for SparkCollectList {
fn default_value(&self, data_type: &DataType) -> Result<ScalarValue> {
empty_list_scalar(data_type)
}
+
+ fn distinct_handling(&self) -> DistinctHandling {
+ DistinctHandling::Unsupported
Review Comment:
Same here. Let's cover the behaviour in the slt.
##########
datafusion/spark/src/function/aggregate/try_sum.rs:
##########
@@ -341,6 +347,14 @@ mod tests {
use super::*;
// -------- Helpers --------
+ #[test]
+ fn try_sum_reports_distinct_as_unsupported() {
+ assert_eq!(
+ SparkTrySum::new().distinct_handling(),
+ DistinctHandling::Unsupported
Review Comment:
Same here. Could we also cover that in the slt file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
