cool9850311 commented on PR #26773: URL: https://github.com/apache/datafusion/pull/26773#issuecomment-6543595737
Rebased onto `main` after #26660; the `min_rows` fix is the one that changed shape rather than position. Description rewritten -- the `Absolute` paragraph is gone and the counts are right. One extra commit from checking related shapes (0406f60a): `limit_behavior` now returns `Window(None)` unless the input order mode is `Sorted`, since a frame's end bound is only a row count when each partition is a contiguous run of the input. Not reachable today -- `get_best_fitting_window` refuses a non-`Sorted` mode for bounded input, and the unbounded plans have no sort below the window -- so it states the precondition rather than fixing a live bug. Happy to drop it if you'd rather keep this PR narrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
