sam-1112 commented on PR #7196: URL: https://github.com/apache/datafusion-comet/pull/7196#issuecomment-6545811402
Thanks, @comphead . I checked the guards and ran the corresponding read-path tests. They support your analysis, so I made the following simplifications: - Removed the repeated-ID last-wins arm, retaining main’s first-wins tie order, and deleted the Rust tests you listed. - Removed `claimed_names`, its per-target `String` clone, and `is_pure_structural_narrowing_denies_conflicting_name_claims`. - Reduced the 12-case repeated-ID Scala matrix to one root and one nested case, preserving the parquet-mr reference check and explicit fallback assertions. - Removed the separate off-heap reproduction block and added `IntegerType` coverage to the existing id-over-name matrix, retaining both field orders and parent nulls. The required/unread-root projection tests and existing duplicate-ID/name fallback guards remain in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
