Himanshu-2005-code commented on PR #24231: URL: https://github.com/apache/datafusion/pull/24231#issuecomment-6547747130
@jayzhan211 Thanks! Restored pub on GlobalRequirements and pushdown_limit_helper. Added required_ordering assertions to test_sort_pushdown_exact_preserves_fetch_with_global_limit and a new test_sort_pushdown_exact_spm_preserves_fetch_with_local_limit for the SPM → LocalLimitExec path. Both fail if the pushdown_sort.rs change is reverted. @bvolpato Since these stay public, GlobalRequirements does lose UnwindSafe/RefUnwindSafe because it now holds an Option<LexOrdering>. That’s a smaller break than making them crate-private. I’ve noted it in the PR description; happy to add the api change label if you think it’s needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
