1cbyc commented on PR #2608: URL: https://github.com/apache/datafusion-ballista/pull/2608#issuecomment-6544748170
> Thanks, this looks good! Small thing, the client retries used to log at `warn` and now go through the shared helper at `debug`, so the "remote shuffle read failed, retrying" line disappears at default log levels. That one's handy when chasing flaky fetches. Would you mind keeping it at `warn` (maybe with the error that triggered the retry, like Noah suggested)? Not a blocker. i have completed those changes. thank you for pointing them out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
