Kristofferjoha commented on code in PR #26747:
URL: https://github.com/apache/datafusion/pull/26747#discussion_r4435011570
##########
datafusion/physical-expr/src/equivalence/class.rs:
##########
@@ -751,6 +754,15 @@ impl EquivalenceGroup {
for (target, _) in targets.iter() {
cls.push(Arc::clone(target));
}
+ // Retain deterministic expressions as equalities so orderings
derived
+ // through strict functions can be inferred after a merge clears
orderings.
+ if !source.children().is_empty() && !is_volatile(source) {
Review Comment:
Outer sort should be retained now, added `Closes #26306` to description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
