alamb commented on code in PR #26845:
URL: https://github.com/apache/datafusion/pull/26845#discussion_r4415715584


##########
datafusion/sqllogictest/test_files/cte.slt:
##########
@@ -1980,7 +1980,7 @@ Plan with Metrics
 07)--------ProjectionExec: expr=[n@0 as n, n@0 + 1 as w.n + Int64(1)], 
metrics=[]
 08)----------FilterExec: n@0 < 5, metrics=[]
 09)------------WorkTableExec: name=w, metrics=[]
-10)--------DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/cte/hash_join_dynamic_filter.parquet]]},
 projection=[k], output_ordering=[k@0 ASC NULLS LAST], file_type=parquet, 
predicate=DynamicFilter [ true ], dynamic_rg_pruning=eligible, 
metrics=[output_rows=4, output_batches=4, files_ranges_pruned_statistics=4 
total → 4 matched, row_groups_pruned_statistics=4 total → 4 matched, 
page_index_pages_pruned=4 total → 4 matched, page_index_rows_pruned=400 total → 
400 matched, limit_pruned_row_groups=0 total → 0 matched, batches_split=0, 
file_open_errors=0, file_scan_errors=0, files_opened=4, files_processed=4, 
num_predicate_creation_errors=0, predicate_evaluation_errors=0, 
pushdown_rows_matched=4, pushdown_rows_pruned=396, 
predicate_cache_inner_records=400, predicate_cache_records=4, 
scan_efficiency_ratio=157.36% (1.14 K/727)]
+10)--------DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/cte/hash_join_dynamic_filter.parquet]]},
 projection=[k], output_ordering=[k@0 ASC NULLS LAST], file_type=parquet, 
predicate=DynamicFilter [ true ], dynamic_rg_pruning=eligible, 
metrics=[output_rows=4, output_batches=4, files_ranges_pruned_statistics=4 
total → 4 matched, row_groups_pruned_statistics=4 total → 4 matched, 
page_index_pages_pruned=4 total → 4 matched, page_index_rows_pruned=400 total → 
400 matched, limit_pruned_row_groups=0 total → 0 matched, batches_split=0, 
file_open_errors=0, file_scan_errors=0, files_opened=4, files_processed=4, 
num_predicate_creation_errors=0, predicate_evaluation_errors=0, 
pushdown_rows_matched=4, pushdown_rows_pruned=396, 
predicate_cache_inner_records=400, predicate_cache_records=4, 
scan_efficiency_ratio=160.67% (1.14 K/712)]

Review Comment:
   percentage difference is due to updatings to the version



##########
dev/release/README.md:
##########
@@ -464,22 +481,37 @@ Caused by:
 Note: [`datafusion` formula](https://formulae.brew.sh/formula/datafusion) is 
[updated 
automatically](https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+datafusion+is%3Aclosed),
 so no action is needed.
 
-### 11. Sync Changelog and Version to main
+### 12. Sync Changelog and Documentation to main
+
+The crate version is **not** synced back to `main`: `main` already carries the

Review Comment:
   FYI @xudong963  -- here is a proposal for how to do versions after the next 
release



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to