alamb commented on PR #12429: URL: https://github.com/apache/datafusion/pull/12429#issuecomment-2345873073
> I also think we should add a basic test to https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/information_schema.slt > > (this file has to be updated on every version bump anyways so adding a test there will not increase the release burden) Since the function has the architecture in its output too, I don't think there is a way to cover it with tests in slt that wouldn't fail on some platforms. We would have to do it via rust tests where we could `#cfg(` on the target os. I think it is ok to merge as is and I will make a PR shortly to add a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
