tschwarzinger commented on PR #26822: URL: https://github.com/apache/datafusion/pull/26822#issuecomment-6576267909
I think apart from moving `VariantType` to the other package this looks good! After that we can add the display integration. From what I can gather, the display implementation is mostly done in [datafusion-variant](https://github.com/sdf-jkl/datafusion-variant/blob/b2c1f91a31ea94b0e50e6a8e828988791d8ecd5b/src/variant_display.rs). Should we add this code to this PR or do a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
