devtechedge commented on PR #2618: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2618#issuecomment-6596836087
Thanks for the detailed look. Those two lines came from a local clippy run while preparing the branch, not from the DO work. One was a redundant `as_slice()` in `CreateTableOptions` and the other was a `needless_range_loop` rewrite in `parse_window_functions`, so I removed both and the diff now touches the DO files only. On the parser, I applied your suggestion and also dropped the plain `(true, false)` arm, since the new arm handles both cases. I rebased onto main as well, since the branch had conflicts. I also compared thirty `DO` forms against libpg_query, including every form from your earlier reviews, and the accept and reject results agree. `cargo fmt`, clippy and the full test suite pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
