mohitgurav20 commented on PR #26897: URL: https://github.com/apache/datafusion/pull/26897#issuecomment-6598891007
Thanks @alamb, the refactor looks great! Splitting the test fixture into `io/mod.rs` makes the setup much cleaner and reusable across other scan tests, and inline snapshots make reviewing the I/O traces much simpler. Happy with these changes as-is. Once this lands in `main`, I will rebase #25811 on top so the incremental pruning PR shows the skipped Bloom filter read directly in `test_parquet_bloom_filter_io_pruned`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
