pepijnve commented on issue #25329: URL: https://github.com/apache/datafusion/issues/25329#issuecomment-6601281118
> 20\. > Honestly, a colleague of mine ([@pepijnve](https://github.com/pepijnve)) and I have lost track of the overall direction across these issues — where the design is heading and how the various fixes are meant to fit together. > > > I'm sorry I've let this get to this state. I need to invest time that I simply don't have in refreshing my mind on these implementations and tying together all of the loose ends. I'll get to it in the next couple of weeks. > Maybe it would help if I wrote a high level description of what the problem we are trying to solve is in my mind? Or maybe we can add all of the different cases we think are handled wrong as tests and work from there TDD style? No worries @adriangb. @bert-beyondloops and I just got stuck on making progress on this and ended up giving up since we're in the same boat as you are: not enough spare cycles to work on this. Speaking for myself, I think I understand the intention with the "push to leaf" idea. It reminds me of a technique I used in optimising case expressions where you try to discard data you don't need to save on filtering work (see https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/expressions/case.rs#L220 for details). The part that's not so clear for me is what the exact intended semantics of expression placement are. I think I got my interpretation wrong in #25388 where I interpreted 'keep in place' a bit too literally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
