AdamGS commented on code in PR #27015:
URL: https://github.com/apache/datafusion/pull/27015#discussion_r4454067979


##########
datafusion/physical-plan/src/spill/mod.rs:
##########
@@ -2693,6 +2712,64 @@ mod tests {
         Ok(())
     }
 
+    #[rstest::rstest]
+    #[case(SpillCompression::Uncompressed)]
+    #[case(SpillCompression::Lz4Frame)]
+    #[case(SpillCompression::Zstd)]
+    #[tokio::test]
+    async fn test_spill_prunes_unused_nested_dictionary_values(

Review Comment:
   this test makes sense to me, looking at some of the other tests here I don't 
think it fits in any of them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to