vikrantmehta123 commented on issue #26985: URL: https://github.com/apache/datafusion/issues/26985#issuecomment-6612032464
@mkleen Have you started working on this? If not, could I take it up since the PR is closed? This looks approachable for a new contributor. Happy to leave it with you if you've already started working on it. I had analyzed the issue before PR was submitted and rrived at a solution where we keep only two functions: one to decide whether the type is supported or not, and other to decide whether to use the GroupsAccumulator or ordinary accumulator, which I believe corresponds to what you were recommending in the PR comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
