alamb opened a new pull request, #27063:
URL: https://github.com/apache/datafusion/pull/27063

   ## Which issue does this PR close?
   
   - Part of https://github.com/apache/datafusion-sqlparser-rs/issues/2454
   
   Note: this PR is for testing only and is not intended to be merged as-is. 
Once `sqlparser` 0.64.0 is released, the pin will be updated to the released 
version.
   
   ## Rationale for this change
   
   Test DataFusion against the proposed 0.64.0 release of 
[apache/datafusion-sqlparser-rs](https://github.com/apache/datafusion-sqlparser-rs)
 ahead of the release, to find regressions before the release is cut (the same 
exercise as #24926 for 0.63.0).
   
   In particular, it is important that all queries that DataFusion accepts with 
the current sqlparser release must continue to be accepted.
   
   ## What changes are included in this PR?
   
   1. Pin `sqlparser` to git rev `02097a8cc593e26976d8da587f3eaa74c9bde1e8` 
(the version bump branch in 
https://github.com/apache/datafusion-sqlparser-rs/pull/2811)
   2. Update DataFusion for upstream AST changes:
      - `Expr::InList` / `Expr::InSubquery` merged into `Expr::In { target: 
InTarget }`
      - `CreateTable::{without_rowid, strict}` replaced by 
`sqlite_table_options`
      - New `Insert::{by_name, overriding}`, `Update`/`Delete::{on_cluster, 
settings}` fields (rejected as unsupported)
      - `TableFactor::Table::index_hints` renamed to `index_directives`, plus 
new `inheritance` field
      - New `JoinConstraint::UsingAlias`, `ColumnOption::GenericOptions`, 
`CreateFunctionBody::BeginAtomic`, and `DataType::{Object, Zerofill, Collate}` 
variants (rejected as unsupported)
      - `DataType::Custom` modifiers are now `TypeModifier` rather than `String`
   
   ## What is the testing strategy for this PR?
   
   Existing CI (including sqllogictests) run against the new sqlparser version. 
Locally `cargo test -p datafusion-sql`, `cargo test --test sqllogictests`, 
`cargo test -p datafusion --lib` and `cargo clippy --workspace --all-targets` 
pass.
   
   ## Are there any user-facing changes?
   
   Updated sqlparser version. `TableRelationBuilder::index_hints` is renamed to 
`index_directives` and takes `Vec<TableIndexDirective>`.
   
   This PR was prepared with AI assistance (Claude Code).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to