alamb commented on code in PR #27087:
URL: https://github.com/apache/datafusion/pull/27087#discussion_r4473210810
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -370,6 +370,14 @@ struct AccumulatorState {
enum PartitionStatus {
Pending,
Reported(PartitionData),
+ /// The partition's stream was dropped before it delivered its build
report.
+ ///
+ /// The partition counts as complete, so sibling partitions do not wait for
+ /// its report. Its build keys are unknown, but no probe row routed to it
+ /// reaches a consumer: the stream probes only after delivery, and delivery
Review Comment:
I found "a consumer: the stream probes only after delivery, and delivery
/// waits for this filter to be final" confusing
Also if no probe rows are routed to it, why doesn't the join canclel?
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -370,6 +370,14 @@ struct AccumulatorState {
enum PartitionStatus {
Pending,
Reported(PartitionData),
+ /// The partition's stream was dropped before it delivered its build
report.
+ ///
+ /// The partition counts as complete, so sibling partitions do not wait for
+ /// its report. Its build keys are unknown, but no probe row routed to it
+ /// reaches a consumer: the stream probes only after delivery, and delivery
Review Comment:
Is the idea that the output limit was hit or osmething so the join just
needs to shutdown cleanly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
