devanbenz commented on issue #26169:
URL: https://github.com/apache/datafusion/issues/26169#issuecomment-6643687460

   https://github.com/apache/datafusion/issues/27108 Reverting 
https://github.com/apache/datafusion/pull/25790 fixes the Q18 regression. Here 
is tpch sf100 without that change with filter pushdown on:
   
   | query | polars | DataFusion 55.1.0 | main without 25790 | main / polars |
   |---|---:|---:|---:|---:|
   | q01 | 2.02 | 2.68 | 2.60 | 1.29x |
   | q02 | 0.17 | 0.73 | 0.58 | 3.46x |
   | q03 | 1.52 | 2.05 | 1.82 | 1.20x |
   | q04 | 0.76 | 1.03 | 1.28 | 1.68x |
   | q05 | 1.69 | 3.87 | 2.19 | 1.29x |
   | q06 | 0.62 | 0.90 | 1.21 | 1.95x |
   | q07 | 1.96 | 6.90 | 2.11 | 1.07x |
   | q08 | 2.80 | 5.13 | 4.78 | 1.71x |
   | q09 | 4.87 | 10.68 | 7.46 | 1.53x |
   | q10 | 2.44 | 2.41 | 2.26 | 0.93x |
   | q11 | 0.16 | 0.70 | 0.41 | 2.52x |
   | q12 | 0.65 | 0.86 | 1.37 | 2.10x |
   | q13 | 2.29 | 2.40 | 2.78 | 1.21x |
   | q14 | 1.01 | 1.48 | 1.24 | 1.23x |
   | q15 | 0.96 | 3.13 | 2.83 | 2.95x |
   | q16 | 0.44 | 0.48 | 0.43 | 0.99x |
   | q17 | 1.41 | 6.71 | 2.18 | 1.54x |
   | q18 | 2.60 | 6.98 | 6.06 | 2.33x |
   | q19 | 1.10 | 1.47 | 1.60 | 1.46x |
   | q20 | 1.15 | 2.07 | 1.57 | 1.37x |
   | q21 | 3.64 | 11.99 | 14.19 | 3.90x |
   | q22 | 0.42 | 0.42 | 0.47 | 1.12x |
   | **total** | **34.7** | **75.1** | **61.4** | **1.77x** |
   
   Cut down the queries by ~14s :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to